Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/68 #69

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Issues/68 #69

merged 5 commits into from
Nov 1, 2024

Conversation

fjaviersanchez
Copy link
Collaborator

This PR addresses #67 and #68.

It allows the user to use a step size for the derivatives that is proportional to the width of the search space.

@fjaviersanchez fjaviersanchez marked this pull request as draft October 30, 2024 22:25
@fjaviersanchez fjaviersanchez mentioned this pull request Oct 31, 2024
Closed
@fjaviersanchez fjaviersanchez marked this pull request as ready for review October 31, 2024 00:36
@fjaviersanchez
Copy link
Collaborator Author

Any volunteers to review this PR? @elisachisari, @arthurmloureiro? 😅

@arthurmloureiro
Copy link
Collaborator

Any volunteers to review this PR? @elisachisari, @arthurmloureiro? 😅

I can review it!

@arthurmloureiro arthurmloureiro self-requested a review November 1, 2024 09:00
arthurmloureiro
arthurmloureiro approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@arthurmloureiro arthurmloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good!

@fjaviersanchez fjaviersanchez merged commit 7d431d5 into master Nov 1, 2024
1 check passed
@fjaviersanchez
Copy link
Collaborator Author

Thank you! @arthurmloureiro

@fjaviersanchez fjaviersanchez deleted the issues/68 branch November 1, 2024 16:38
@fjaviersanchez fjaviersanchez mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurmloureiro arthurmloureiro arthurmloureiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjaviersanchez @arthurmloureiro